ocamlPackages.conduit: 1.0.0 -> 1.4.0 and dependencies #74821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
requested changes
Dec 5, 2019
vbgl
requested changes
Dec 28, 2019
vbgl
requested changes
Dec 29, 2019
| @@ -1,20 +1,22 @@ | |||
| { stdenv, fetchurl, buildDunePackage, sexplib, ppx_sexp_conv }: | |||
| { stdenv, fetchurl, buildDunePackage, ocaml | |||
There was a problem hiding this comment.
The fetchurl, ocaml and sexplib arguments are not used.
There was a problem hiding this comment.
Yikes, sorry to force several rounds of this on you. Thanks for staying on top of things.
I just found https://github.com/Synthetica9/nix-linter and used that to find any pesky leftovers.
vbgl
approved these changes
Dec 29, 2019
|
@GrahamcOfBorg build ocamlPackages.cohttp-lwt-unix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/mirage/ocaml-conduit/blob/master/CHANGES.md#v140
https://github.com/mirage/ocaml-ipaddr/blob/master/CHANGES.md#v310-2019-03-02
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @