Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.irmin: init at 1.4.0 #74818

Merged
merged 5 commits into from Dec 24, 2019
Merged

ocamlPackages.irmin: init at 1.4.0 #74818

merged 5 commits into from Dec 24, 2019

Conversation

alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Dec 2, 2019

Motivation for this change

Dependency of tezos

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@yorickvP
Copy link
Contributor

yorickvP commented Dec 2, 2019

Hi there! Are you packaging tezos? We did this work a while ago. Managed to produce some static binaries for it, too. Here's the set of overrides we used to get it to build

@yorickvP
Copy link
Contributor

yorickvP commented Dec 2, 2019

Also, feel free to cherry-pick some of https://github.com/serokell/nixpkgs/commits/ocaml-cross-fixes

@alexfmpe
Copy link
Member Author

alexfmpe commented Dec 2, 2019 •
edited

Hi there! Are you packaging tezos? We did this work a while ago. Managed to produce some static binaries for it, too. Here's the set of overrides we used to get it to build

Yeah, kind of. I did something similar to that gist to get dune build to work at the root (using mainnet so far), and thought I might as well upstream the derivations. Yours seem slightly more up-to-date though, I haven't needed ipaddr 4.0.0 for instance (though the dune file does state >= 4.0). Admittedly I haven't actually checked anything other than "does this actually produce a working binary" yet.

Also, feel free to cherry-pick some of https://github.com/serokell/nixpkgs/commits/ocaml-cross-fixes

Oh thanks

vbgl
vbgl requested changes Dec 2, 2019
View reviewed changes
pkgs/development/ocaml-modules/irmin/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/irmin/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/irmin/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/irmin/default.nix Outdated Show resolved Hide resolved
@yorickvP
Copy link
Contributor

yorickvP commented Dec 3, 2019

@alexfmpe I was also just told about https://github.com/serokell/tezos-client-packaging, which produces static tezos client binaries

alexfmpe and others added 4 commits December 19, 2019 02:18
@alexfmpe @vbgl
Apply suggestions from code review
9017bd8 
Co-Authored-By: Vincent Laporte <vbgl@users.noreply.github.com>
@alexfmpe
Rename file
c5298c9
@alexfmpe
Cleanup
dab24b6
@alexfmpe
Use fetchurl directly
ea0a875
@vbgl vbgl merged commit c7a9cb0 into NixOS:master Dec 24, 2019
@marsam marsam mentioned this pull request Sep 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexfmpe @yorickvP @vbgl