Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ferm: 2.4.1 -> 2.5 #74841

Merged
merged 1 commit into from Apr 19, 2020
Merged

ferm: 2.4.1 -> 2.5 #74841

merged 1 commit into from Apr 19, 2020

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Dec 2, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

@ofborg ofborg bot requested a review from Mic92 December 2, 2019 17:14
c0bw3b
c0bw3b reviewed Dec 2, 2019
View reviewed changes
pkgs/tools/networking/ferm/default.nix
url = "http://ferm.foo-projects.org/download/2.4/ferm-${version}.tar.xz";
sha256 = "1fv8wk513yysp4q0i65rl2m0hg2lxwwgk9ppprsca1xcxrdpsvwa";
url = "http://ferm.foo-projects.org/download/${majorMinor version}/ferm-${version}.tar.xz";
sha256 = "0lxqcpirphihpvdqrh5kq0621aqq0h2vdy9q2v85gqdhd52js20p";
};

buildInputs = [ perl ipset ebtables iptables makeWrapper ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick but) makeWrapper should be in nativeBuildInputs

@Mic92
Copy link
Member

Mic92 commented Dec 3, 2019

@GrahamcOfBorg test ferm

@Ekleog
Copy link
Member

Ekleog commented Apr 19, 2020

While I agree with @c0bw3b's comment that makeWrappershould probably be in nativeBuildInputs, this wasn't introduced by this PR, so we're only improving things by merging it, not making anything worse. Merging as a consequence :)

@Ekleog Ekleog merged commit 2d6f734 into NixOS:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tilpner @Mic92 @Ekleog @c0bw3b