Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash-completion: Fix tests with musl. #74813

Merged
merged 1 commit into from Dec 2, 2019
Merged

bash-completion: Fix tests with musl. #74813

merged 1 commit into from Dec 2, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Dec 2, 2019 •
edited

Motivation for this change

Fixes test error

self = <test_iconv.TestIconv object at 0x7ffff52f3410>
completion = <CompletionResult []>

    @pytest.mark.complete("iconv -")
    def test_1(self, completion):
>       assert completion
E       assert <CompletionResult []>

../t/test_iconv.py:7: AssertionError

by applying upstream commit not present in a newer release.

See

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

@nh2 nh2 requested a review from peti December 2, 2019 03:19
@nh2
Copy link
Contributor Author

nh2 commented Dec 2, 2019

Still building for me.

@GrahamcOfBorg build pkgsMusl.bash-completion

@nh2
bash-completion: Fix tests with musl.
0a85437 
Fixes test error

    self = <test_iconv.TestIconv object at 0x7ffff52f3410>
    completion = <CompletionResult []>

        @pytest.mark.complete("iconv -")
        def test_1(self, completion):
    >       assert completion
    E       assert <CompletionResult []>

    ../t/test_iconv.py:7: AssertionError

by applying upstream commit not present in a newer release.
@nh2 nh2 force-pushed the musl-bash-completion-patch branch from 88df6d2 to 0a85437 Compare December 2, 2019 03:20
@nh2
Copy link
Contributor Author

nh2 commented Dec 2, 2019

@GrahamcOfBorg build pkgsMusl.bash-completion

@nh2
Copy link
Contributor Author

nh2 commented Dec 2, 2019

Still building for me.

Done now.

@Mic92 Mic92 merged commit 0106804 into NixOS:master Dec 2, 2019
@Mic92
Copy link
Member

Mic92 commented Dec 2, 2019

I changed it to be applied unconditionally: 8031617

@nh2 nh2 mentioned this pull request Dec 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @Mic92