Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amber: 0.5.2 -> 0.5.3 #74802

Merged
merged 1 commit into from Dec 2, 2019
Merged

amber: 0.5.2 -> 0.5.3 #74802

merged 1 commit into from Dec 2, 2019

Conversation

bdesham
Copy link
Contributor

@bdesham bdesham commented Dec 1, 2019

Motivation for this change

Just an update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bdesham
Copy link
Contributor Author

bdesham commented Dec 1, 2019

@GrahamcOfBorg build amber

@lsix
Copy link
Member

lsix commented Dec 2, 2019

Built and tested here. Thanks.

@lsix lsix merged commit 5a3dcb5 into NixOS:master Dec 2, 2019
@bdesham bdesham deleted the amber-0.5.3 branch December 2, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdesham @lsix