Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-driver.py: sleep in between executing things periodically inside the vm #74868

Closed
wants to merge 1 commit into from
Closed

test-driver.py: sleep in between executing things periodically inside the vm #74868

wants to merge 1 commit into from

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 2, 2019

while it's fine to use an endless loop on a blocking socket, we
can't do the same with executing commands inside the VM. instead, wait
1sec in between each interval.

Motivation for this change

I saw a lot of spam while waiting for a wait_until_succeeds method to finish inside a nixos vm test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

@flokli
test-driver.py: sleep in between executing things periodically inside…
e363948 
… the vm

while it's fine to use an endless loop on a blocking socket, we
can't do the same with executing commands inside the VM. instead, wait
1sec in between each interval.
@tfc
Copy link
Contributor

tfc commented Dec 3, 2019

Hey @flokli this is not the right approach. The perl test driver uses the retry primitive to loop with intervals between the retrys. Yesterday i started converting the python test driver functions to the same style, which will also fix the problems this PR tackles. Would you be fine with closing this PR and waiting for my PR?

@tfc tfc mentioned this pull request Dec 3, 2019
Merged
10 tasks
@tfc
Copy link
Contributor

tfc commented Dec 3, 2019

see #74898

@flokli
Copy link
Contributor Author

flokli commented Dec 4, 2019

Closing in favor of #74898.

@flokli flokli closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @tfc