Fix WPT test: content-security-policy/reporting/report-only-unsafe-eval.html #20560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 2, 2019
…al.html This test doesn't pass, because there is a problem with Chrome's implementation (See https://crbug.com/980127) and because there are two problems in the test itself. 1) t_spv.done() is never called. 2) A typing mistake in "tsv_unreached_func" Bug: 980127 Change-Id: I91949f64db3f3d7d3033d559d8e277b2cb980b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946482 Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#720890}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1946482
branch
from
3dfbe6e
to
789f041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test doesn't pass, because there is a problem with Chrome's
implementation (See https://crbug.com/980127) and because there are two
problems in the test itself.
Bug: 980127
Change-Id: I91949f64db3f3d7d3033d559d8e277b2cb980b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946482
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720890}