Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdk-pixbuf: fix setup hook #74785

Merged
merged 1 commit into from Dec 1, 2019
Merged

gdk-pixbuf: fix setup hook #74785

merged 1 commit into from Dec 1, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 1, 2019

b78e840 tried to make the script better but used the wrong test
syntax: [[ 113 > 99 ]] is false. This caused the librsvg not being added
to $GDK_PIXBUF_MODULE_FILE.

Fixes: #73586 (comment)

cc @Ericson2314 @c0bw3b @d-goldin

b78e840 tried to make the script better but used the wrong test
syntax: [[ 113 > 99 ]] is false. This caused the librsvg not being added
to $GDK_PIXBUF_MODULE_FILE.

Fixes: NixOS#73586 (comment)
@jtojnar jtojnar added the 1.severity: channel blocker Blocks a channel label Dec 1, 2019
@d-goldin
Copy link
Contributor

d-goldin commented Dec 1, 2019

@jtojnar: Great, this looks like exactly the issue. I will give it a quick testrun.

@d-goldin
Copy link
Contributor

d-goldin commented Dec 1, 2019

Adwaita builds and naturally GDK_PIXBUF_MODULE_FILE points to the correct librsvg loaders.cache 👍

@FRidh
Copy link
Member

FRidh commented Dec 1, 2019

This can go to master as we currently don't have any staging-next either.

@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 1, 2019

I think the issue is only in staging at the moment.

@FRidh
Copy link
Member

FRidh commented Dec 1, 2019

Oh, it builds on other changes in staging. Never mind then.

@FRidh FRidh added this to Ready in Staging Dec 1, 2019
@FRidh FRidh merged commit d4b4bcd into NixOS:staging Dec 1, 2019
Staging automation moved this from Ready to Done Dec 1, 2019
@jtojnar jtojnar deleted the gdk-pixbuf-fix branch December 1, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants