Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.django: 1.11.24 -> 1.11.26 #74902

Merged
merged 1 commit into from Dec 19, 2019
Merged

pythonPackages.django: 1.11.24 -> 1.11.26 #74902

merged 1 commit into from Dec 19, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Dec 3, 2019

See

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@lsix
Copy link
Member Author

lsix commented Dec 3, 2019

I’ll port it to release-19.09 once merged.

jonringer
jonringer reviewed Dec 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the django ecosystem could use some love

[167 built (20 failed), 276 copied (320.7 MiB), 99.0 MiB DL]
error: build of '/nix/store/81gp5b9iq35y9mg2v52fq8bxj119sznv-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74902
4 package are marked as broken and were skipped:
python27Packages.django_evolution python27Packages.django_pipeline python37Packages.django_pipeline python38Packages.django_pipeline

26 package failed to build:
python27Packages.django-cors-headers python27Packages.django-filter python27Packages.django-rest-auth python27Packages.django-sesame python27Packages.django_guardian python27Packages.djangorestframework python27Packages.djangorestframework-jwt python27Packages.easy-thumbnails python27Packages.thumbor python37Packages.django-sesame python37Packages.django_guardian python37Packages.easy-thumbnails python37Packages.google_cloud_error_reporting python37Packages.google_cloud_logging python37Packages.hyperkitty python37Packages.mailman-web python37Packages.postorius python37Packages.sentry-sdk python38Packages.django-sesame python38Packages.django_guardian python38Packages.easy-thumbnails python38Packages.google_cloud_error_reporting python38Packages.google_cloud_logging python38Packages.hyperkitty python38Packages.mailman-web python38Packages.postorius

163 package were built:
buildbot buildbot-full buildbot-ui mkdocs octoprint python27Packages.django python27Packages.django-cleanup python27Packages.django-configurations python27Packages.django-csp python27Packages.django-discover-runner python27Packages.django-dynamic-preferences python27Packages.django-haystack python27Packages.django-ipware python27Packages.django-jinja python27Packages.django-logentry-admin python27Packages.django-multiselectfield python27Packages.django-pglocks python27Packages.django-picklefield python27Packages.django-q python27Packages.django-sampledatahelper python27Packages.django-sites python27Packages.django-sr python27Packages.django-storages python27Packages.django_appconf python27Packages.django_classytags python27Packages.django_colorful python27Packages.django_compat python27Packages.django_compressor python27Packages.django_contrib_comments python27Packages.django_environ python27Packages.django_extensions python27Packages.django_hijack python27Packages.django_hijack_admin python27Packages.django_nose python27Packages.django_polymorphic python27Packages.django_redis python27Packages.django_reversion python27Packages.django_silk python27Packages.django_tagging python27Packages.django_treebeard python27Packages.djangoql python27Packages.djmail python27Packages.filebrowser_safe python27Packages.libthumbor python27Packages.livereload python27Packages.mezzanine python27Packages.pelican python27Packages.pytest-django python27Packages.sentry-sdk python27Packages.suseapi python27Packages.typogrify python37Packages.channels python37Packages.channels-redis python37Packages.django python37Packages.django-allauth python37Packages.django-cleanup python37Packages.django-configurations python37Packages.django-cors-headers python37Packages.django-csp python37Packages.django-discover-runner python37Packages.django-dynamic-preferences python37Packages.django-filter python37Packages.django-haystack python37Packages.django-ipware python37Packages.django-jinja python37Packages.django-logentry-admin python37Packages.django-mailman3 python37Packages.django-multiselectfield python37Packages.django-pglocks python37Packages.django-picklefield python37Packages.django-q python37Packages.django-rest-auth python37Packages.django-sampledatahelper python37Packages.django-sites python37Packages.django-sr python37Packages.django-storages python37Packages.django_appconf python37Packages.django_classytags python37Packages.django_colorful python37Packages.django_compat python37Packages.django_compressor python37Packages.django_contrib_comments python37Packages.django_environ python37Packages.django_extensions python37Packages.django_hijack python37Packages.django_hijack_admin python37Packages.django_nose python37Packages.django_polymorphic python37Packages.django_redis python37Packages.django_reversion python37Packages.django_silk python37Packages.django_tagging python37Packages.django_taggit python37Packages.django_treebeard python37Packages.djangoql python37Packages.djangorestframework python37Packages.djangorestframework-jwt python37Packages.djmail python37Packages.filebrowser_safe python37Packages.libthumbor python37Packages.livereload python37Packages.mezzanine python37Packages.pelican python37Packages.pyjade python37Packages.pytest-django python37Packages.suseapi python37Packages.typogrify python38Packages.channels python38Packages.channels-redis python38Packages.django python38Packages.django-allauth python38Packages.django-cleanup python38Packages.django-configurations python38Packages.django-cors-headers python38Packages.django-csp python38Packages.django-discover-runner python38Packages.django-dynamic-preferences python38Packages.django-filter python38Packages.django-haystack python38Packages.django-ipware python38Packages.django-jinja python38Packages.django-logentry-admin python38Packages.django-mailman3 python38Packages.django-multiselectfield python38Packages.django-pglocks python38Packages.django-picklefield python38Packages.django-q python38Packages.django-rest-auth python38Packages.django-sampledatahelper python38Packages.django-sites python38Packages.django-sr python38Packages.django-storages python38Packages.django_appconf python38Packages.django_classytags python38Packages.django_colorful python38Packages.django_compat python38Packages.django_compressor python38Packages.django_contrib_comments python38Packages.django_environ python38Packages.django_extensions python38Packages.django_hijack python38Packages.django_hijack_admin python38Packages.django_nose python38Packages.django_polymorphic python38Packages.django_redis python38Packages.django_reversion python38Packages.django_silk python38Packages.django_tagging python38Packages.django_taggit python38Packages.django_treebeard python38Packages.djangoql python38Packages.djangorestframework python38Packages.djangorestframework-jwt python38Packages.filebrowser_safe python38Packages.libthumbor python38Packages.livereload python38Packages.mezzanine python38Packages.pelican python38Packages.pyjade python38Packages.pytest-django python38Packages.suseapi python38Packages.typogrify redo-apenwarr

@jonringer
Copy link
Contributor

a lot of the packages have dropped support for python2

@lsix
Copy link
Member Author

lsix commented Dec 4, 2019

Yes, python2 is close to retirement (less than 1 month from now https://pythonclock.org/). Having projects dropping its support is a good thing if you ask me.

From what I can see, all the 26 failed dependent derivations also fails on master, this is not linked to this PR.

@jonringer
Copy link
Contributor

still, touching the django ecosystem doesn't happen too often, it would be nice to get the nix-review to reflect the current state of dependent packages

@FRidh
Copy link
Member

FRidh commented Dec 4, 2019

could mark django at python 2.7 as broken

@lsix
Copy link
Member Author

lsix commented Dec 4, 2019

This will be done soon.

django-1.11 is the last LTR branch supporting python2, and it reach EOL by april 2020. So before release-20.03, I plan to turn django-2.2 the main django branch supported in nixpkgs, turning off python2 support in the same time.

@duijf
Copy link
Contributor

duijf commented Dec 5, 2019

looks like the django ecosystem could use some love

FYI: This PR fixes the sentry-sdk build: #75039

@lsix lsix merged commit 05caa97 into NixOS:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lsix @jonringer @FRidh @duijf