pythonPackage.progressbar2: Fix #74867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Dec 3, 2019
The `postPatch` phase is failing when no `.pyc` file is generated in `tests` by the build (`rm: missing operand` error). As per @jonringer's comment, the whole `postPatch` is not needed anymore.
Pamplemousse
force-pushed
the
fix_progressbar2
branch
from
a601dac
to
ec1a445
Compare
jonringer
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
LGTM
baseline failures are from gym being broken on master
[4 built (3 failed), 45 copied (774.7 MiB), 513.1 MiB DL]
error: build of '/nix/store/2cbbbcz2q03qv9fljjh8h41lblrj1qvm-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74867
1 package are marked as broken and were skipped:
python27Packages.baselines
2 package failed to build:
python37Packages.baselines python38Packages.baselines
4 package were built:
python27Packages.progressbar2 python37Packages.progressbar2 python38Packages.progressbar2 truvari
|
@GrahamcOfBorg build python27Packages.progressbar2 python37Packages.progressbar2 python38Packages.progressbar2 truvari |
|
Thank you @Pamplemousse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
progressbar2build fails on my machine.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @ashgillman