Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CORB coverage for application/pdf into //services/network. #20570

Merged
merged 1 commit into from Dec 9, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Dec 2, 2019

After MimeHandlerViewInCrossProcessFrame shipped, application/pdf can
be blocked by CORB in a //chrome-agnostic way (similarly to how
//services/network layer knows about and blocks application/zip).

In particular, the current CL has been unblocked by the recent removal
of kMimeHandlerViewInCrossProcessFrame feature in r720036 - see:
https://chromium-review.googlesource.com/c/chromium/src/+/1869121/26/chrome/browser/net/system_network_context_manager.cc
and
https://chromium-review.googlesource.com/c/chromium/src/+/1869121/26/content/public/common/content_features.cc

Bug: 533069
Change-Id: I9af8db439fbe270cc3519fc5c6c4699c5842a7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946846
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722621}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

After MimeHandlerViewInCrossProcessFrame shipped, application/pdf can
be blocked by CORB in a //chrome-agnostic way (similarly to how
//services/network layer knows about and blocks application/zip).

In particular, the current CL has been unblocked by the recent removal
of kMimeHandlerViewInCrossProcessFrame feature in r720036 - see:
https://chromium-review.googlesource.com/c/chromium/src/+/1869121/26/chrome/browser/net/system_network_context_manager.cc
and
https://chromium-review.googlesource.com/c/chromium/src/+/1869121/26/content/public/common/content_features.cc

Bug: 533069
Change-Id: I9af8db439fbe270cc3519fc5c6c4699c5842a7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946846
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#722621}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants