Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Athame-zsh #74804

Closed
wants to merge 3 commits into from
Closed

NEW Athame-zsh #74804

wants to merge 3 commits into from

Conversation

BananchickPasha
Copy link
Contributor

Motivation for this change

There wasn't this package so i decided to add it

Things done

It works, but user has to create ~/.athamerc manually.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ahiaao
Copy link
Contributor

ahiaao commented Dec 1, 2019

I recommend rereading CONTRIBUTING.md. Specifically the sections about commit messages and meta.description.

This does not seem to respect the directory structure. Maybe move pkgs/shells/zsh/athame-zsh.nix to pkgs/shells/zsh/zsh-athame/default.nix

athame and vimbed should probably be packaged separately.

Do you actually need to override zsh? The other zsh addons do not seem to need to do this.

Are you able to reference the patch you are applying in postPatch in the actual patch stage? Also are two of those lines in postPatch just comments? If so, then those should be removed.

prusnak
prusnak requested changes Dec 2, 2019
View reviewed changes
pkgs/shells/zsh/athame-zsh.nix
@@ -0,0 +1,39 @@
{stdenv, vim, zsh, ncurses, isNeovim ? false}:
let athame = fetchGit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use fetchFromGitHub

pkgs/shells/zsh/athame-zsh.nix
rev = "ded4200cb3312334d99ace794c4b308cd45f6b6e";
url = "https://github.com/ardagnir/athame";
};
vimbed = fetchGit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use fetchFromGitHub

maintainers/maintainer-list.nix
@@ -7670,4 +7670,9 @@
githubId = 52650;
name = "Marc Busqué";
};
bananPasha = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use BananchickPasha instead of bananPasha to match the GitHub username

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@Artturin Artturin closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BananchickPasha @ahiaao @prusnak @ryantm @Artturin