Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing width in "#def-draw-error" style has no effect #469

Open
ghost opened this issue Sep 2, 2019 · 5 comments
Open

Changing width in "#def-draw-error" style has no effect #469

ghost opened this issue Sep 2, 2019 · 5 comments

Comments

@ghost
Copy link

ghost commented Sep 2, 2019

System information

SolveSpace version: 3.0~22e4011c

Operating system: Debian 9.x stretch (x86_64)

Expected behavior

Changing any parameter of any style should work as expected.

Actual behavior

Changing width in #def-draw-error style has no effect.

pic.1

Additional information

@whitequark
Copy link
Contributor

whitequark commented Sep 2, 2019

What really should happen here is that the built-in styles shouldn't allow changing any items that don't actually affect the drawing. But this is fairly annoying to track down.

@ghost
Copy link
Author

ghost commented Dec 1, 2019

Changing width in #def-draw-error style has no effect.

Found that similar issue happen with #def-selected line style (only color changing has effect for this style), but it reuse width and stipple type from #def-active-grp instead.

@whitequark
Copy link
Contributor

That's intended. The bug here is that the built-in style lets you change this parameter.

@ghost
Copy link
Author

ghost commented Dec 1, 2019

The bug here is that the built-in style lets you change this parameter.

Sometime, changing built-in styles are really needed.

For example, if I want set "red" background, default built-in "red" highlighting for selected entities is mostly useless.

pic.1

User should has possibility to tune default UI & styles according personal preferences

@whitequark
Copy link
Contributor

Sometime, changing built-in styles are really needed.

You misunderstood. Being able to change e.g. selected entity color is useful and intended. The problem is that although the #def-selected style exists only to allow you to change selected entity color, it shows many more changeable parameters that do not affect anything. These parameters should not be shown.

@whitequark whitequark added the UI label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant