[ChromeDriver] Workaround DevTools fullscreen issue #20573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 3, 2019
Add some workaround code while setting browser window to fullscreen mode, to work around an issue in DevTools fullscreen command. In particular, call document.documentElement.requestFullscreen() to ensure that document.webkitIsFullScreen returns the correct values. All WPT tests related to fullscreen now pass. Also made an adjustment to WPT set_window_rect/set.py test_fully_exit_fullscreen, which was using a width below the minimum supported by Chrome. Bug: 982071 Change-Id: I0e50883c3f67a566df1bc4ffd331aeac0b0ef1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947816 Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721019}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1947816
branch
from
1507b0a
to
a376448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some workaround code while setting browser window to fullscreen
mode, to work around an issue in DevTools fullscreen command. In
particular, call document.documentElement.requestFullscreen() to ensure
that document.webkitIsFullScreen returns the correct values. All WPT
tests related to fullscreen now pass.
Also made an adjustment to WPT set_window_rect/set.py
test_fully_exit_fullscreen, which was using a width below the minimum
supported by Chrome.
Bug: 982071
Change-Id: I0e50883c3f67a566df1bc4ffd331aeac0b0ef1e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947816
Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721019}