Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.09] haproxy: add patches for CVE-2019-19330 #74794

Closed
wants to merge 1 commit into from
Closed

[r19.09] haproxy: add patches for CVE-2019-19330 #74794

wants to merge 1 commit into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Dec 1, 2019 •
edited

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-19330

Patch needed a small amount of context-adjustment to apply, so included in-repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle
Copy link
Contributor Author

risicle commented Dec 1, 2019 •
edited

Actually - only one of these three patches needs context adjustment. I think I'm going to pull in the unadjusted ones using fetchpatch instead of balling the whole thing up into a single patch. Stay tuned... Ok, all done.

@risicle risicle force-pushed the ris-haproxy-CVE-2019-19330-r19.09 branch from 591dde7 to 6e49464 Compare December 1, 2019 18:16
@risicle
Copy link
Contributor Author

risicle commented Dec 1, 2019

Closing this in favour of bumping to 1.9.13 instead. I wasn't aware of its existence because upstream keep stable branches in totally separate repos.

@risicle risicle closed this Dec 1, 2019
@risicle risicle mentioned this pull request Dec 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @veprbl