Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reviewdog: 0.9.12 -> 0.9.14 #74798

Merged
merged 1 commit into from Dec 8, 2019
Merged

reviewdog: 0.9.12 -> 0.9.14 #74798

merged 1 commit into from Dec 8, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 1, 2019

Motivation for this change

Changelog: https://github.com/reviewdog/reviewdog/releases/tag/v0.9.14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit December 1, 2019 18:45
@marsam
Copy link
Contributor Author

marsam commented Dec 1, 2019

@GrahamcOfBorg build reviewdog

@Lassulus
Copy link
Member

Lassulus commented Dec 7, 2019

getting this error on reviewing:

$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/lass/.cache/nix-review/pr-74798/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/6jkjxbcpk97lvvlv673fcacbkzmh32bm-reviewdog-0.9.14.drv' failed with exit code 1; last 10 log lines:
  go: downloading github.com/xanzy/go-gitlab v0.22.1
  go: downloading golang.org/x/net v0.0.0-20191126235420-ef20fe5d7933
  go: extracting github.com/reviewdog/errorformat v0.0.0-20191201164258-85eb1c3cc6e3
  go: extracting github.com/xanzy/go-gitlab v0.22.1
  go: downloading github.com/google/go-github/v28 v28.1.1
  go: downloading github.com/mattn/go-shellwords v1.0.6
  go: extracting github.com/mattn/go-shellwords v1.0.6
  go: extracting github.com/google/go-github/v28 v28.1.1
  go: downloading golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
  verifying golang.org/x/net@v0.0.0-20191126235420-ef20fe5d7933: golang.org/x/net@v0.0.0-20191126235420-ef20fe5d7933: Get https://sum.golang.org/lookup/golang.org/x/net@v0.0.0-20191126235420-ef20fe5d7933: dial tcp: lookup sum.golang.org on [::1]:53: read udp [::1]:34913->[::1]:53: read: connection refused
cannot build derivation '/nix/store/mz3xdijsvcj9z24d06l4vf1px17admww-env.drv': 1 dependencies couldn't be built
[2 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/mz3xdijsvcj9z24d06l4vf1px17admww-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74798
1 package failed to build:
reviewdog

@marsam marsam mentioned this pull request Dec 7, 2019
Merged
10 tasks
@marsam
Copy link
Contributor Author

marsam commented Dec 7, 2019

Thanks for reviewing, it was failing because an issue with buildGoModule #74811

Lassulus
Lassulus approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit fc8596b into NixOS:master Dec 8, 2019
@marsam marsam deleted the update-reviewdog branch December 8, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @Lassulus