Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.[open]ldap: port to python #74851

Merged
merged 2 commits into from Dec 4, 2019
Merged

nixosTests.[open]ldap: port to python #74851

merged 2 commits into from Dec 4, 2019

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Dec 2, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @worldofpeace @Lassulus

@tfc tfc mentioned this pull request Dec 2, 2019
Closed
@ofborg ofborg bot added the 6.topic: nixos label Dec 2, 2019
@tfc
Copy link
Contributor Author

tfc commented Dec 2, 2019

@GrahamcOfBorg test ldap openldap

Lassulus
Lassulus approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flokli flokli changed the title Nixos test ldap python nixosTests.[open]ldap: port to python Dec 2, 2019
@flokli
Copy link
Contributor

flokli commented Dec 2, 2019

Can you update the two commit messages to start with nixosTests.ldap / nixosTests.openldap?

@tfc
Copy link
Contributor Author

tfc commented Dec 3, 2019

Can you update the two commit messages to start with nixosTests.ldap / nixosTests.openldap?

the contributing guide says it would be nixos/ldap: msg and nixos/openldap: msg. Where does the new requirement come from?

(pkg-name | nixos/<module>): (from -> to | init at version | refactor | etc)

(Motivation for change. Additional information.)

@flokli
Copy link
Contributor

flokli commented Dec 4, 2019

You're working on the tests, not the [open]ldap modules. The tests are exposed under the nixosTests.[open]ldap attribute.

@tfc
Copy link
Contributor Author

tfc commented Dec 4, 2019

@flokli done

@flokli
Copy link
Contributor

flokli commented Dec 4, 2019

@GrahamcOfBorg test openldap ldap

@flokli flokli merged commit afd8bb3 into NixOS:master Dec 4, 2019
@tfc tfc deleted the nixos-test-ldap-python branch December 4, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tfc @flokli @Lassulus