Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libffi: 3.2.1 -> 3.3 #74855

Merged
merged 2 commits into from Dec 3, 2019
Merged

libffi: 3.2.1 -> 3.3 #74855

merged 2 commits into from Dec 3, 2019

Conversation

matthewbauer
Copy link
Member

  • Bump libffi to 3.3.
  • Remove some patches that are no longer necessary.
  • Add myself as maintainer.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer
libffi: 3.2.1 -> 3.3
53a04a2
@matthewbauer
libffi: update meta
7c1539b 
- add myself as maintainer
- license is mit
@matthewbauer matthewbauer changed the base branch from master to staging December 2, 2019 21:46
@matthewbauer matthewbauer merged commit 5f6b8d4 into NixOS:staging Dec 3, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 3, 2019
@matthewbauer @dtzWill
Merge pull request NixOS#74855 from matthewbauer/libffi-3.3
381a08b 
libffi: 3.2.1 -> 3.3
(cherry picked from commit 5f6b8d4)
@timokau
Copy link
Member

timokau commented Dec 14, 2019

This broke the ecl build. More information on that here and here. We could temporarily fix that by reverting this commit.

@timokau timokau mentioned this pull request Dec 14, 2019
Merged
10 tasks
@jtojnar
Copy link
Contributor

jtojnar commented Dec 15, 2019 •
edited

@timokau how can that be so? We were already doing that in postFixup in 3.2.1. Perhaps false positive during rebase?

@timokau
Copy link
Member

timokau commented Dec 16, 2019

You're right, I must've made some mistake. Another bisect showed that a different commit was responsible. Fix: #75801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @timokau @jtojnar