New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyperopt: init at 0.2.2 #74783
hyperopt: init at 0.2.2 #74783
Conversation
This issue is now solved, however there is still a problem with the tests. The full log is here: https://gist.github.com/GuillaumeDesforges/9aa019307f05d98065d7f4c6f85f4f21 The main issue seems to be that files that are not
How can I add them to the list of files to copy ? |
Have you tried consulting upstream? |
if it's needed for normla usage, then adding a files makes sense. Still unusual if needed though |
The FileNotFound issue can be resolved by fetching from GitHub instead of pypy: src = fetchFromGitHub {
owner = "hyperopt";
repo = "hyperopt";
rev = version;
sha256 = "1x9nasjlck408f86bvb23vy31py1rjcy9bjqicy30bclrdbmh6x9";
}; which is weird since it seems like they should be distributing that file over pypi. That gives the next test failure however, which is due to a newer numpy version and some numerical instability: Other relevant issues: And unfortunately this is not meregable with the networkx pin, since we cannot use multiple versions of networks in parallel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
I believe they would have to list the file(s) in their MANIFEST.in or list it as a data_dir in their A lot of packages just assume you're going to pull down their wheel and blindly install what you get from pypi. |
I think that this line is supposed to do just that and add all the data automatically: |
That's just to refactor out the logic, the important part is passing it to setup() https://github.com/hyperopt/hyperopt/blob/b593d18ada68abe96e84b43055dec0cc799a5891/setup.py#L146 either way, both parts are necessary, and the data should be getting exported if it's able to correctly find the data |
Deleted forked repo, recreated it, so I needed to create a new PR #82144 Sorry for the inconvenience. |
Motivation for this change
hyperopt
was not part of nixpkgs.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Additional information
I have tested the package using the example from hyperopt readme.