Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fido2luks: init at 0.2.2 #74780

Merged
merged 1 commit into from Jan 12, 2020
Merged

fido2luks: init at 0.2.2 #74780

merged 1 commit into from Jan 12, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Dec 1, 2019

Motivation for this change

New package allowing to use of FIDO2 tokens for LUKS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@prusnak prusnak changed the title fido2: init at unstable-2019-10-12 fido2luks: init at unstable-2019-10-12 Dec 1, 2019
Ekleog
Ekleog previously requested changes Dec 14, 2019
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single nit on the implementation.

However, on the idea… This software appears to have been released once, in beta only (without any tag), two months ago on reddit, and to have seen no change since then -- hinting at little maintenance, though this is by no means a definitive answer.

I'm not opposed to including it, if it solves a problem that no other software currently solves. But I want to check: if you have the hardware it appears designed to work with, have you actually already tested it locally? Does it work properly? Does it have issues, or is it the “perfect” piece of software its 0 issues would let one assume?

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@prusnak
Copy link
Member Author

prusnak commented Dec 15, 2019

@Ekleog Good points. I did the initial packaging so my colleague could test it. Let's keep this open and wait until we properly test it.

@Ekleog
Copy link
Member

Ekleog commented Dec 15, 2019

Great, thanks! I found this through triage, and there's a risk I completely forget about it, so when you've tested it, don't hesitate to ping me on freenode#nixos

@prusnak prusnak changed the title fido2luks: init at unstable-2019-10-12 fido2luks: init at 0.2.2 Jan 11, 2020
@ofborg ofborg bot requested a review from mmahut January 11, 2020 14:22
@prusnak
Copy link
Member Author

prusnak commented Jan 11, 2020

I am in contact with the developer and he is eager to keep developing this. In fact, he just published a new stable release on Github which is packaged here. @mmahut is a co-maintainer and will try to integrate this with NixOS.

Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I'll let @mmahut handle the decision to merge, as he seems involved :)

@mmahut
Copy link
Member

mmahut commented Jan 12, 2020

Thanks, verified the package works fine.

Now the fun part, integration :)

@mmahut mmahut merged commit 48b537e into NixOS:master Jan 12, 2020
@prusnak prusnak deleted the fido2luks branch January 12, 2020 21:18
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 12, 2020
fido2luks: init at 0.2.2
(cherry picked from commit 48b537e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants