New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fido2luks: init at 0.2.2 #74780
fido2luks: init at 0.2.2 #74780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single nit on the implementation.
However, on the idea… This software appears to have been released once, in beta only (without any tag), two months ago on reddit, and to have seen no change since then -- hinting at little maintenance, though this is by no means a definitive answer.
I'm not opposed to including it, if it solves a problem that no other software currently solves. But I want to check: if you have the hardware it appears designed to work with, have you actually already tested it locally? Does it work properly? Does it have issues, or is it the “perfect” piece of software its 0 issues would let one assume?
@Ekleog Good points. I did the initial packaging so my colleague could test it. Let's keep this open and wait until we properly test it. |
Great, thanks! I found this through triage, and there's a risk I completely forget about it, so when you've tested it, don't hesitate to ping me on freenode#nixos |
I am in contact with the developer and he is eager to keep developing this. In fact, he just published a new stable release on Github which is packaged here. @mmahut is a co-maintainer and will try to integrate this with NixOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I'll let @mmahut handle the decision to merge, as he seems involved :)
Thanks, verified the package works fine. Now the fun part, integration :) |
fido2luks: init at 0.2.2 (cherry picked from commit 48b537e)
Motivation for this change
New package allowing to use of FIDO2 tokens for LUKS.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @