nixos/test: Use retry() in all looping functions that need timeouts #74898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Maybe using the decorator from https://pypi.org/project/retry/ or https://pypi.org/project/retrying/ would be nicer. |
On the one hand: Yes. On the other hand: an extra dependency for such a little function seems like too much. What do you think? |
flokli
requested changes
Dec 4, 2019
| @@ -1,4 +1,4 @@ | |||
| import ./make-test.nix ({ ... }: | |||
There was a problem hiding this comment.
This should go in a separate PR.
There was a problem hiding this comment.
Well, at least it's 2 separate commits, so we can merge this as is.
Still, please open 2 separate PRs next time.
|
@GrahamcOfBorg test pam-oath-login |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#72828
Related to #74868. Use
retryin all functions that should wait between retries and also timeout after some time so a test won't hang forever. These changes also resemble what the original perl driver does.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @worldofpeace @flokli