buildGoModule: disable consult the checksum database on build #74811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since Go 1.13,
GOSUMDB
defaults to "sum.golang.org", to consult thechecksum database of the main module's go.sum.
We already use the default behavior when building
go-modules
, but Gotries to consult the checksum database again when building the module,
and fails because since it requires
cacert
andgit
, which are notpropagated when building the package.
example failure: https://github.com/NixOS/nixpkgs/pull/74798/checks?check_run_id=328167165
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc: @kalbasit, @c00w, @rvolosatovs