Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluxctl: 1.15.0 -> 1.16.0 #74909

Merged
merged 2 commits into from Dec 6, 2019
Merged

fluxctl: 1.15.0 -> 1.16.0 #74909

merged 2 commits into from Dec 6, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 3, 2019

Motivation for this change

https://github.com/fluxcd/flux/releases/tag/1.16.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Gonzih


This change is Reviewable

Copy link
Contributor

@Gonzih Gonzih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested via nix-review
@kalbasit could you please click that merge button?

@nlewo nlewo merged commit fe6592b into NixOS:master Dec 6, 2019
@Br1ght0ne Br1ght0ne deleted the fluxctl-1.16.0 branch December 6, 2019 09:15
@Gonzih
Copy link
Contributor

Gonzih commented Dec 6, 2019

hey @nlewo, could you please also take a look at #72289? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants