Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zim: Fix missing icons #74829

Merged
merged 1 commit into from Dec 10, 2019
Merged

zim: Fix missing icons #74829

merged 1 commit into from Dec 10, 2019

Conversation

tenaf0
Copy link
Contributor

@tenaf0 tenaf0 commented Dec 2, 2019

Motivation for this change

Zim doesn't have some icons on plasma5

Things done

Added adwaita icon theme as build input, as per Homebrew/homebrew-core#43897

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pSub

@ofborg ofborg bot requested a review from pSub December 2, 2019 12:35
@pSub pSub merged commit 09dec10 into NixOS:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tenaf0 @pSub @Janik-Haag