Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gebaar-libinput: init at 0.0.5 #74896

Merged
merged 1 commit into from Dec 16, 2019
Merged

gebaar-libinput: init at 0.0.5 #74896

merged 1 commit into from Dec 16, 2019

Conversation

lovesegfault
Copy link
Member

Motivation for this change

Wasn't packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @colemickens @andir

@ofborg ofborg bot requested a review from colemickens December 3, 2019 07:48
@lovesegfault
Copy link
Member Author

All fixed, thanks @jtojnar!

@lovesegfault
Copy link
Member Author

is this ready @jtojnar @colemickens?

doronbehar
doronbehar requested changes Dec 6, 2019
View reviewed changes
pkgs/tools/inputmethods/gebaar-libinput/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@lovesegfault
Copy link
Member Author

@jtojnar, @doronbehar, @colemickens: Ready for another review round.

@marsam
Copy link
Contributor

marsam commented Dec 16, 2019

@GrahamcOfBorg build gebaar-libinput

@marsam marsam merged commit c2be9fe into NixOS:master Dec 16, 2019
@marsam
Copy link
Contributor

marsam commented Dec 16, 2019

Thank you @lovesegfault.
I made a minor change, I hope you don't mind

@lovesegfault lovesegfault deleted the geebar-libinput branch April 7, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@colemickens colemickens Awaiting requested review from colemickens

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lovesegfault @marsam @jtojnar @doronbehar