[Gecko Bug 1600624] Fix import rules to properly unlink their stylesheet from its parent. #20579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test is hopefully self-explanatory. The children setup here is a bit bogus as noted here and other comments, will file a followup to clean it up. Differential Revision: https://phabricator.services.mozilla.com/D55550 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1600624 gecko-commit: d3c543e00e2d3da21ce642f4b3c92cfda016b404 gecko-integration-branch: autoland gecko-reviewers: heycam
Using an array is much better to reason about than a manually linked list, and allows us to preserve @import order. Added a test for a bug that we happened not to have, but that it's not covered by existing WPT tests. Differential Revision: https://phabricator.services.mozilla.com/D55565 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1600624 gecko-commit: 1019f8467d744a1c318a3199955e5c2ee7a08d99 gecko-integration-branch: autoland gecko-reviewers: heycam
wpt-pr-bot
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is hopefully self-explanatory. The children setup here is a bit bogus as
noted here and other comments, will file a followup to clean it up.
Differential Revision: https://phabricator.services.mozilla.com/D55550
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1600624
gecko-commit: d3c543e00e2d3da21ce642f4b3c92cfda016b404
gecko-integration-branch: autoland
gecko-reviewers: heycam