@andir could you also update firefox-esr? If so, I will close #74907 as a duplication.

@andir could you also update firefox-esr? If so, I will close #74907 as a duplication.

Yes, will do. Will push once the build succeeds.

Tested with nix-review and run for an hour without issues.

Can you check if it builds with Rust 1.39? Currently we have a line inherit (rustPackages_1_38_0) cargo rustc; in firefoxPackages which would be nice to get rid of.

Can you check if it builds with Rust 1.39? Currently we have a line inherit (rustPackages_1_38_0) cargo rustc; in firefoxPackages which would be nice to get rid of.

Firefox will probably work (at least 71.x) but the tor browser will not work just yet.

I am planning on reworking the way we are currently passing packages into this as it isn't very flexible enough for the variants of packages we are building with firefoxPackages.

staging-next got merged.

The firefox version bump seems to break indexedDB at least for some extensions and thus prevents saving their preferences on my machine. This happening both on master and 19.09. The issue has also been reported upstream and websites also seem to be affected though I haven't tested this yet. We should revert the firefox bump ASAP, at least on 19.09!

Fedora has the same problems: https://bugzilla.redhat.com/show_bug.cgi?id=1779762

One of the upstream reports is here: https://bugzilla.mozilla.org/show_bug.cgi?id=1601365

And this might be the root cause: https://bugzilla.mozilla.org/show_bug.cgi?id=1601707. We don't have GCC9 and thus might not be affected by the actual segfault described there but Comment 7 suggests that more fixes are needed to get extensions to work.

I will continue to investigate but wanted to share my findings as soon as possible.

Since this has been verified by some other people, I've reverted it on 19.09 now because this change was already part of a 19.09 channel release.

I can confirm this on release-19.09 (in my case one symptom was that riot couldn't decrypt messages in encrypted rooms - in case anyone else stumbles upon this) and the revert fixes the problem.

Folks who use channels rather than the git branches to build their systems (latest channel release for 19.09 was 8 hours ago which means that this package is part of it) can work around the issue by either using firefox-bin for now or by including the firefox package from the git branch (e.g. (import builtins.fetchGit ... {}).firefox) rather than pkgs.firefox, it seems as most of the build artifacts in the binary cache for firefox can be reused, at least I didn't have to rebuild :)