Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: spectral-cube: 0.4.4 -> 0.4.5 #74826

Merged
merged 1 commit into from Dec 3, 2019
Merged

python: spectral-cube: 0.4.4 -> 0.4.5 #74826

merged 1 commit into from Dec 3, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented Dec 2, 2019 •
edited

Motivation for this change

Update spectral-cube to the latest upstream. The current version in nixpkgs (0.4.4) is broken because the tests fail (radio-astro-tools/spectral-cube#591). This new release fixes the tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret @marsam
python: spectral-cube: 0.4.4 -> 0.4.5
efd657f 
Co-Authored-By: Mario Rodas <marsam@users.noreply.github.com>
@marsam marsam merged commit 0e03637 into NixOS:master Dec 3, 2019
@marsam
Copy link
Contributor

marsam commented Dec 3, 2019

Thanks!

@smaret smaret deleted the spectral-cube-0.4.5 branch December 3, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaret @marsam