Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1600459] Fix an individual transform parsing test. #20550

Merged
merged 1 commit into from Dec 2, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

Per spec it should serialize percentages before pixels:

https://drafts.csswg.org/css-values-4/#sort-a-calculations-children

Differential Revision: https://phabricator.services.mozilla.com/D55373

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1600459
gecko-commit: 4f9740b2be4e8cda8913bb17a02917b1fe506306
gecko-integration-branch: autoland
gecko-reviewers: hiro

Per spec it should serialize percentages before pixels:

  https://drafts.csswg.org/css-values-4/#sort-a-calculations-children

Differential Revision: https://phabricator.services.mozilla.com/D55373

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1600459
gecko-commit: 4f9740b2be4e8cda8913bb17a02917b1fe506306
gecko-integration-branch: autoland
gecko-reviewers: hiro
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@dbaron
Copy link
Member

dbaron commented Dec 1, 2019

The Community-TC failures all seem to be things like:

CRITICAL: task_head points at b6d74c9, expected db4cdb4. This may be because the branch was updated

(I didn't check if they're all the same hashes.)

@dbaron
Copy link
Member

dbaron commented Dec 1, 2019

cc @emilio

@emilio
Copy link
Contributor

emilio commented Dec 1, 2019

Hmm, what should I do about this? Rebasing or something? @jgraham

@jgraham
Copy link
Contributor

jgraham commented Dec 2, 2019

Ah, I guess this check also fails if master is updated between the decision task and the subsequent jobs. I'll need to change something here… In the meantime close and reopen should work.

@jgraham jgraham closed this Dec 2, 2019
@jgraham jgraham reopened this Dec 2, 2019
@moz-wptsync-bot moz-wptsync-bot merged commit 7cc8448 into master Dec 2, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1600459 branch December 2, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants