Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: gdb: Make target-independent and auto-load-safe-path with a wrapper #74808

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

WIP: gdb: Make target-independent and auto-load-safe-path with a wrapper #74808

wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Member

Motivation for this change

The libgcc/compiler-rt used varies with the target platform.

I checked, and lldb doesn't have a similar notion of load prefix path,
so this stays a one-off wrapper for gdb for now.

Need to test to make sure all cross stuff works as expected.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ericson2314
gdb: Make target-independent and auto-load-safe-path with a wrapper
9141785 
The libgcc/compiler-rt used varies with the target platform.

I checked, and lldb doesn't have a similar notion of load prefix path,
so this stays a one-off wrapper for gdb for now.
@ofborg ofborg bot requested review from lovek323, nbp and globin December 1, 2019 22:54
@veprbl veprbl added this to WIP in Staging via automation Dec 1, 2019
matthewbauer
matthewbauer reviewed Dec 2, 2019
View reviewed changes
pkgs/development/tools/misc/gdb/wrapper.nix
, gdb-unwrapped
, safePaths ? [
# $debugdir:$datadir/auto-load are whitelisted by default by GDB
"$debugdir" "$datadir/auto-load"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't be needed when you don't pass the with-auto-load-safe-path option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thank you I accidentally added them back when I rebased.

@FRidh FRidh moved this from WIP to Needs review in Staging Dec 31, 2019
@FRidh FRidh moved this from Needs review to WIP in Staging Dec 31, 2019
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:04
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@Mic92 Mic92 Awaiting requested review from Mic92

@tmplt tmplt Awaiting requested review from tmplt

@lovek323 lovek323 Awaiting requested review from lovek323

@nbp nbp Awaiting requested review from nbp

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
WIP
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @matthewbauer @ryantm