Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages_latest.phylogenetics: init at unstable-2019-11-15 #74837

Merged
merged 7 commits into from Dec 6, 2019
Merged

ocamlPackages_latest.phylogenetics: init at unstable-2019-11-15 #74837

merged 7 commits into from Dec 6, 2019

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Dec 2, 2019

Motivation for this change

Add Biocaml, Gnuplot-Ocaml, and Phylogenetics packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bcdarwin bcdarwin force-pushed the biocaml branch 2 times, most recently from eb63c7b to f6bc3f5 Compare December 2, 2019 16:43
@bcdarwin bcdarwin force-pushed the biocaml branch 2 times, most recently from 094f01b to 0886406 Compare December 3, 2019 14:01
@bcdarwin bcdarwin force-pushed the biocaml branch 2 times, most recently from 6345efc to 275a665 Compare December 4, 2019 21:54
vbgl
vbgl reviewed Dec 6, 2019
View reviewed changes
pkgs/top-level/ocaml-packages.nix
@@ -291,6 +295,10 @@ let

gmap = callPackage ../development/ocaml-modules/gmap { };

gnuplot = callPackage ../development/ocaml-modules/gnuplot {
inherit (pkgs) gnuplot;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please similarly fix the input to metrics-unix. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no metrics-unix on this branch; did you mean to comment somewhere else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one in master. Please rebase and we’ll be good to go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Now there is a metrics-unix whose input you can fix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you're asking.

Also, what does metrics-unix have to do with this package? Shouldn't that be a separate issue/PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ocamlPackages.metrics-unix package takes as input gnuplot from the main package set. This PR changes this input: it gives ocamlPackages.gnuplot instead of pkgs.gnuplot.

Copy link
Member Author

@bcdarwin bcdarwin Dec 6, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't see that. Done, metrics-unix builds correctly.

@vbgl
Copy link
Contributor

vbgl commented Dec 6, 2019

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_08.phylogenetics

@vbgl vbgl merged commit 34084d4 into NixOS:master Dec 6, 2019
@bcdarwin bcdarwin deleted the biocaml branch December 6, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @vbgl