Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Mesa recently stopped installing
EGL/eglplatform.h
because it is provided bylibglvnd
.epoxy
's headers includeseglplatform.h
, andepoxy
is in turn required bygtk3
. This caused the build ofgtk3
to fail on armv7l. The reason it didn't fail on other platforms is thatlibGL
(which propagateslibglvnd
) is normally propagated bycairo
. Back in 2013, GL support was disabled in cairo on 32-bit ARM because apparently mesa didn't build. This is no longer the case, so this PR re-enables GL support in cairo on ARM and MIPS. I don't have a way to test MIPS, and I'm not even sure anyone tests it anymore.This PR does not fix the root cause of the problem, which is that
epoxy.dev
should propagatelibGL.dev
(or maybelibglvnd.dev
), but I'll leave that to others if they want to tackle it.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
gtk3: @7c6f434c @vcunat @lethalman @worldofpeace
epoxy: @cillianderoiste
cairo: nobody...