Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor VRPose to fit better with WebXr concepts #20572

Merged
merged 1 commit into from Dec 6, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Dec 3, 2019

This changes pose_reset and input_state attributes that lived on VRPose
to instead live on XRFrameData. This de-couples some frame state from
VRPose and paves the way for it to be used instead of gfx::Transforms
for some entities.

Bug: 1017872
Change-Id: I76474845436168a144f929c8cb94bd4a50b15fe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945278
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721135}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1945278 branch 2 times, most recently from de67e54 to 2df370b Compare December 3, 2019 19:01
This changes pose_reset and input_state attributes that lived on VRPose
to instead live on XRFrameData. This de-couples some frame state from
VRPose and paves the way for it to be used instead of gfx::Transforms
for some entities.

Bug: 1017872
Change-Id: I76474845436168a144f929c8cb94bd4a50b15fe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945278
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721135}
@stephenmcgruer
Copy link
Contributor

@LukeZielinski the multiTouchPoints.html and multiTouchPointsWithPause.html testdriver tests seems to be causing us quite the headache on Chrome; they are now passing whereas before they were crashing? Can you look at this and fixup whatever needs fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants