Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few issues here. Most of them either cancelled each other
out or (due to overrides) weren't hit.
match the spec, and hopefully prevent further confusion
right thing in this case, and so were unaffected.
inversion due to the next issue.
As a result, the xrFrame_getPose test has had it's matrix updated and a
new test has been added which should hopefully help catch this.
Note that if a grip or target space is supplied as the first parameter
to getPose (the common case), the math is being done correctly.
Also note that the two inversions for references spaces also mostly
cancels each other right.
The main issue that was affected is if a reference space with an origin
offset was supplied as the first parameter to xrFrame.getPose
Fixed: 1030049
Change-Id: I0184607dbd0fef991c382289e1c764f9a1b336a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947629
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721105}