Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.chainer: 6.4.0 -> 6.5.0 #74871

Merged
merged 1 commit into from Dec 4, 2019
Merged

python3Packages.chainer: 6.4.0 -> 6.5.0 #74871

merged 1 commit into from Dec 4, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 3, 2019 •
edited

Motivation for this change

Noticed it was broken, decided to bump and add some tests

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

optuna broken on master

[0 built (1 failed), 1 copied (6.3 MiB), 1.4 MiB DL]
error: build of '/nix/store/hmv45ckrsm7v4jcfvqvk95hdslf4h8j5-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74871
1 package failed to build:
python37Packages.optuna

2 package were built:
python37Packages.chainer python38Packages.chainer

@jonringer jonringer requested a review from FRidh as a code owner December 3, 2019 00:38
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.chainer python38Packages.chainer

@jonringer jonringer merged commit c064c2a into NixOS:master Dec 4, 2019
@jonringer jonringer deleted the fix-chainer branch February 13, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer