Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compton/picom: 7.2 -> 7.5 #74831

Merged
merged 2 commits into from Jan 3, 2020
Merged

compton/picom: 7.2 -> 7.5 #74831

merged 2 commits into from Jan 3, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Dec 2, 2019 •
edited

Also change the derivation attribute and name to Picom, a maintained
fork of Compton.

Picom creates compton binaries too, so no config changes required elsewhere.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ertes @Enzime @Twey

@dtzWill
Copy link
Member

dtzWill commented Dec 2, 2019

Commits between 7.2 and 7.5 show that the primary change was the rename, with commits addressing a few memory leaks (and some non-functional cleanup).

Assuming the rename is done right (everything still evals? :P), this seems safe to me :).

Oh, actually:

  • Please rename the directory to reflect the new name (compton -> picom)
  • The NixOS module needs to be updated similarly-- both renaming the file and updating to use pkgs.picom.
  • Please add an alias, so that users of pkgs.compton are warned but not broken.

@adisbladis
compton/picom: 7.2 -> 7.5
74f5c7f 
Also change the derivation attribute and name to Picom, a maintained
fork of Compton.
@adisbladis
nixos/compton: Rename module to picom
aec68f4 
With a backwards compatibility alias
@adisbladis adisbladis merged commit 3dd9020 into NixOS:master Jan 3, 2020
@jtojnar jtojnar mentioned this pull request Jul 4, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @dtzWill