Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skydive: remove it from nixpkgs #68355

Merged
merged 1 commit into from Sep 10, 2019
Merged

skydive: remove it from nixpkgs #68355

merged 1 commit into from Sep 10, 2019

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Sep 9, 2019

The current Skydive version can not be build with a recent Go version
and the maintainer (@nlewo) is no longer interested in maintaining it.

Motivation for this change

The pr #68195 is removing Go 1.11 which is required to compile the current Skydive version.
I've tried to package the latest version, but the build is tricky, it requires several missing dependencies and i'm no longer using Skydive.

However, if someone is interested in maintaining it, I can help to update it (i have something almost working but no more time to work on it).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nlewo
skydive: remove it from nixpkgs
636e155 
The current Skydive version can not be build with a recent Go version
and the maintainer (lewo) is no longer interested in maintaining it.
@lheckemann
Copy link
Member

Since we don't have a maintainer, we should probably backport this to 19.09 as well, right?

@lheckemann lheckemann added this to the 19.09 milestone Sep 10, 2019
@nlewo
Copy link
Member Author

nlewo commented Sep 10, 2019

@lheckemann yes, I could do it.

@worldofpeace worldofpeace merged commit 0f3f515 into NixOS:master Sep 10, 2019
@worldofpeace
Copy link
Contributor

backported in fcd7d6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlewo @lheckemann @worldofpeace