New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sycl-info: init at unstable-2019-11-19 #73723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please resolve conflicts |
davidtwco
force-pushed
the
sycl-info-init
branch
from
February 18, 2020 16:45
4ab9f72
to
a89b5df
Compare
@jonringer thanks, I've resolved the conflicts. |
jonringer
reviewed
Feb 18, 2020
davidtwco
force-pushed
the
sycl-info-init
branch
from
February 18, 2020 17:00
a89b5df
to
ba1a51d
Compare
jonringer
reviewed
Feb 18, 2020
davidtwco
force-pushed
the
sycl-info-init
branch
from
February 18, 2020 17:34
ba1a51d
to
9911d7d
Compare
jonringer
reviewed
Feb 20, 2020
davidtwco
force-pushed
the
sycl-info-init
branch
from
February 20, 2020 09:58
9911d7d
to
f42c697
Compare
jonringer
reviewed
Feb 20, 2020
davidtwco
force-pushed
the
sycl-info-init
branch
from
February 20, 2020 17:39
f42c697
to
025117d
Compare
jonringer
reviewed
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
jonringer
changed the title
sycl-info: init at efbe6d5
sycl-info: init at unstable-2019-11-19
Feb 21, 2020
Signed-off-by: David Wood <david@davidtw.co>
Signed-off-by: David Wood <david@davidtw.co>
Signed-off-by: David Wood <david@davidtw.co>
davidtwco
force-pushed
the
sycl-info-init
branch
from
February 21, 2020 10:02
025117d
to
8a79688
Compare
@jonringer fixed those issues! |
jonringer
approved these changes
Feb 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commits LGTM
[7 built, 12 copied (31.6 MiB), 6.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73723
3 package built:
doctest lyra sycl-info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds a package for sycl-info.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc me!