Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sycl-info: init at unstable-2019-11-19 #73723

Merged
merged 3 commits into from Feb 22, 2020
Merged

Conversation

davidtwco
Copy link
Member

Motivation for this change

Adds a package for sycl-info.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc me!

@jonringer
Copy link
Contributor

please resolve conflicts

@davidtwco
Copy link
Member Author

@jonringer thanks, I've resolved the conflicts.

pkgs/development/libraries/doctest/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/lyra/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/sycl-info/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/sycl-info/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/doctest/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/lyra/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/sycl-info/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/libraries/lyra/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/doctest/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/sycl-info/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/sycl-info/default.nix Outdated Show resolved Hide resolved
@jonringer jonringer changed the title sycl-info: init at efbe6d5 sycl-info: init at unstable-2019-11-19 Feb 21, 2020
Signed-off-by: David Wood <david@davidtw.co>
Signed-off-by: David Wood <david@davidtw.co>
Signed-off-by: David Wood <david@davidtw.co>
@davidtwco
Copy link
Member Author

@jonringer fixed those issues!

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

[7 built, 12 copied (31.6 MiB), 6.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73723
3 package built:
doctest lyra sycl-info

@jonringer jonringer merged commit b0d7d85 into NixOS:master Feb 22, 2020
@davidtwco davidtwco deleted the sycl-info-init branch March 31, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants