New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
darwin.cctools: 895 -> 927.0.2 #73721
darwin.cctools: 895 -> 927.0.2 #73721
Conversation
please rebase onto staging |
Update the version of `cctools` on darwin. The older version fails to work on some modern packages, such as `bazel 1.1`.
d2c7d60
to
7b77c09
Compare
@FRidh done. |
Any thoughts on this? |
Thanks. I don't know anything about Darwin packages so probably best is to wait for or ping Darwin maintainers that are interested in this. |
Friendly ping for @matthewbauer also @alyssais and @volth , "recent" committers. Would love to get this landed soon if possible. |
@FRidh I've pinged all the maintainers and folks who have "recently" changed this derivation, but with no response. Suggestions on who to ping now / how to get this merged? |
@virusdave This PR appears to be a desirable update, however, please keep in mind that nixpkgs is a community-driven project and maintainers are volunteers who work on their schedule. I believe, @matthewbauer is the most knowledgeable for reviewing this PR, so let's wait for what he has to say. If you would like to help us with reviewing the PR, please document carefully what steps did you take to validate your change (we are looking to ensure that nothing is broken by this). From my personal experience, seeing that you did your "homework" helps maintainers to prioritize reviewing your PR over other work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have experience with bumping cctools so I'm not sure if the version should match the rest of the stdenv and apple SDKs. In which case it might require more testing, other then that it looks good to me.
libtool is not really needed and it interferes with updateAutotoolsGnuConfigScriptsHook. So remove it when cross-compiling, but leave it in native to preserve hashes.
…/update_darwin_cctools
Looks good, have included a few misc iOS fixes on top of it. |
Update the version of
cctools
on darwin. The older version failsto work on some modern packages, such as
bazel 1.1
.Motivation for this change
Latest
bazel
package builds, but doesn't work at runtime on darwin, due to this dependency. When i attempted rerunning the runtime failures using the (newer) system cctools binaries from 927.0.2, they work fine, hence this update PR.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)(*) This command succeeded after the rebase onto
staging
, but i don't believe it did anything interesting. It certainly didn't build any derivations.Notify maintainers
cc @matthewbauer