Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 943508a7fa95
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 9abc97dc652a
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 19, 2019

  1. bind: Expand description of services.bind.cacheNetworks 

    The new description should give more clear understanding of when to
edit the option.

I used NixOS to set up a DNS server that is authoritative for certain
zones.  The description of the `cacheNetworks` option made me think I
needed to set it to `"any"` to allow people to query the zone I set
up.  Reading the source of the module would have clarified my
understanding, but at the time I just read the description and thought
little of it.  Later I discovered I was getting tons of DNS requests
and presumably being used for a DNS amplification attack or similar.
I have fixed the problem now, but I would like the option to have a
clearer description so others don't make the same mistake I did.
    @willghatch @Lassulus
    willghatch authored and Lassulus committed Nov 19, 2019
    Copy the full SHA
    9abc97d View commit details
    Browse the repository at this point in the history