Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7836: check coherency of newgrf parameter min/max #7840

Merged
merged 2 commits into from Nov 23, 2019

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Nov 18, 2019

No description provided.

src/newgrf_config.cpp Outdated Show resolved Hide resolved
@glx22
Copy link
Contributor Author

glx22 commented Nov 19, 2019

Checking the values earlier (and ignoring incoherent ones) seems better for me.

@glx22
Copy link
Contributor Author

glx22 commented Nov 19, 2019

BTW I noticed it's not possible to enter values > 999 999 999 in the GUI. I tried increasing max_len in ShowQueryString() call, but it's still not possible to go above 2 147 483 647 because atoi() is used for the conversion.

Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entering high numbers is probably a separate issue, crash is more important

@LordAro LordAro merged commit d865916 into OpenTTD:master Nov 23, 2019
@glx22 glx22 deleted the fix_7836 branch November 24, 2019 00:03
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants