Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endless-sky: 0.9.8 -> 0.9.10 #73719

Merged
merged 1 commit into from Nov 19, 2019
Merged

endless-sky: 0.9.8 -> 0.9.10 #73719

merged 1 commit into from Nov 19, 2019

Conversation

willghatch
Copy link
Contributor

Motivation for this change

New upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [?] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

I ran that command inside my working git repo with the updated package definition. It said it “No diff detected”. I'm really not sure how that review tool is supposed to be run. Is that what I'm supposed to do, or is it something completely different? At any rate, I don't think any other package depends on endless-sky, but I'm not really sure how to verify that.

  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lheckemann

@ofborg ofborg bot requested a review from lheckemann November 18, 2019 22:38
@lheckemann
Copy link
Member

@GrahamcOfBorg build endless-sky

@lheckemann
Copy link
Member

Thanks, completely missed this release since there was no blog post about it!

@lheckemann lheckemann merged commit ff1ead8 into NixOS:master Nov 19, 2019
@willghatch
Copy link
Contributor Author

@lheckemann, thanks for merging! But since I'll likely send more PRs to nixpkgs, would you mind clarifying for me the nix-review bullet point? Are you supposed to just run that command inside your working git clone of nixpkgs, or are you supposed to do something else? Or is there somewhere other than the PR template that explains it?

@lheckemann
Copy link
Member

First off: none of the bullet points are hard requirements, except being fine with the licencing as outlined in CONTRIBUTING.md.

As for nix-review, I'm not entirely sure. I think it's for testing unstaged changes in your git checkout, which is of course quite an individual workflow preference. In addition, since endless-sky is a leaf package (nothing depends on it), there's not much point in using it beyond checking if ES itself builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willghatch @lheckemann