Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azcopy: 10.0.1 -> 10.3.2 #73613

Merged
merged 1 commit into from Dec 9, 2019
Merged

azcopy: 10.0.1 -> 10.3.2 #73613

merged 1 commit into from Dec 9, 2019

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Nov 18, 2019 •
edited

Upgrades azcopy to latest, uses buildGo112Module to work around issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@colemickens
Copy link
Member Author

Note, at one point in 's history, this built with 10.3.1. I tested this PR with 10.3.1 as well, it fails in the same way. So, it seems like something has changed in nixpkgs such that this is occuring.

@ofborg ofborg bot requested a review from kalbasit November 18, 2019 08:48
@colemickens
Copy link
Member Author

colemickens commented Nov 24, 2019 •
edited

It appears there's precedent with another package for using the 1.12 builder. I don't really understand it, but it unblocks upgrading the build. Should be good to go.
(ref:

nixpkgs/pkgs/top-level/all-packages.nix

Line 2617 in 78cb116

# Version 1.2.0 fails to build with go 1.13 due to:
)

@colemickens colemickens changed the title HELP NEEDED: azcopy: v10.0.1 -> v10.3.2 azcopy: 10.0.1 -> 10.3.2 Nov 24, 2019
@colemickens colemickens mentioned this pull request Dec 2, 2019
Merged
10 tasks
marsam
marsam reviewed Dec 7, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I've added a few suggestions, besides that LGTM

pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/azcopy/default.nix Show resolved Hide resolved
pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@colemickens
Copy link
Member Author

Thanks @marsam for the great review! I've made those changes and have updated this branch/PR.

marsam
marsam reviewed Dec 9, 2019
View reviewed changes
pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
@colemickens
Copy link
Member Author

Thanks, hopefully this looks a bit better.

@marsam
Copy link
Contributor

marsam commented Dec 9, 2019

Thanks! I've made minor changes, I hope you don't mind

@GrahamcOfBorg build azure-storage-azcopy

@marsam marsam merged commit 29d242a into NixOS:master Dec 9, 2019
@colemickens colemickens deleted the nixpkgs-azcopy branch January 30, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @marsam