Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/ids: Add types to allow overrides on static uids, gids #73614

Merged
merged 1 commit into from Nov 18, 2019

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 18, 2019

Motivation for this change

This allows overriding the static user ids and group ids.
It fixes the situation where a user module tries to redefine an id. Previously the id would be determined by the module loading order (?), but now it requires lib.mkForce and ambiguities will be detected.
This undetected nondeterminism has caused a regression on our systems by suddenly ignoring an important override.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@infinisil infinisil merged commit 01037b3 into NixOS:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants