Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.coc-nvim-2019-11-18 #73740

Merged
merged 2 commits into from Nov 19, 2019
Merged

vimPlugins.coc-nvim-2019-11-18 #73740

merged 2 commits into from Nov 19, 2019

Conversation

lovesegfault
Copy link
Member

Motivation for this change

coc-nvim doesn't really tag releases anymore, they have a release branch that they continuously update, so this bumps the version as such, and adds a note.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer

@lovesegfault lovesegfault changed the title Vim plugins.coc nvim 2019 11 18 vimPlugins.coc-nvim-2019-11-18 Nov 19, 2019
@lovesegfault lovesegfault mentioned this pull request Nov 19, 2019
Closed
@ofborg ofborg bot added the 6.topic: vim label Nov 19, 2019
@ofborg ofborg bot requested a review from jagajaga November 19, 2019 06:13
@teto
Copy link
Member

teto commented Nov 19, 2019

The naming guidelines say it should be renamed to coc-unstable then.
https://nixos.org/nixpkgs/manual/#sec-package-naming
it would be cool if we could compile from source. Something like with yarn2nix. Any interest in pursuing this ?

@jonringer
Copy link
Contributor

jonringer commented Nov 19, 2019 •
edited

vimplugins are an exception @teto. The norm is to just use the date of the latest commit. The additions are largely done through an update script https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/vim.section.md#adding-new-plugins-to-nixpkgs

jonringer
jonringer approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM

[38 built, 40 copied (911.8 MiB), 211.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73740
20 package were build:
vimPlugins.coc-nvim vimPlugins.defx-nvim vimPlugins.denite-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-nvim vimPlugins.fzf-vim vimPlugins.gist-vim vimPlugins.neco-vim vimPlugins.neoformat vimPlugins.vim-addon-xdebug vimPlugins.vim-commentary vimPlugins.vim-fugitive vimPlugins.vim-go vimPlugins.vim-jsx-pretty vimPlugins.vim-mucomplete vimPlugins.vim-obsession vimPlugins.vim-table-mode vimPlugins.vimtex vimPlugins.webapi-vim vimPlugins.youcompleteme

@jonringer jonringer merged commit 19b5055 into NixOS:master Nov 19, 2019
@lovesegfault lovesegfault deleted the vimPlugins.coc-nvim-2019-11-18 branch April 7, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @teto @jonringer