Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasksh: enable on Darwin #73691

Merged
merged 1 commit into from Nov 20, 2019
Merged

tasksh: enable on Darwin #73691

merged 1 commit into from Nov 20, 2019

Conversation

eraserhd
Copy link
Contributor

This works fine for me, which is unsurprising.

Motivation for this change

Enable use of this on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 18, 2019
@Mic92
Copy link
Member

Mic92 commented Nov 18, 2019

@GrahamcOfBorg build tasksh

@alyssais
Copy link
Member

Is there any reason it shouldn’t be platforms.unix? Or even platforms.all?

@eraserhd
Copy link
Contributor Author

Changed to "platforms.unix", based on contents of INSTALL and CMakeLists.txt.

@Mic92
Copy link
Member

Mic92 commented Nov 20, 2019

@GrahamcOfBorg build tasksh

@Mic92 Mic92 merged commit ce75a06 into NixOS:master Nov 20, 2019
@eraserhd eraserhd deleted the dogfood branch November 24, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants