Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwupd: 1.2.10 → 1.3.3 #73700

Merged
merged 1 commit into from Nov 20, 2019
Merged

fwupd: 1.2.10 → 1.3.3 #73700

merged 1 commit into from Nov 20, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 18, 2019 •
edited

https://github.com/fwupd/fwupd/blob/1.3.2/data/org.freedesktop.fwupd.metainfo.xml#L35-L90

  • systemd.tmpfiles should not be necessary, as the systemd service switched to StateDirectory.
  • built on NixOS with sandboxing
  • ran the installed tests
  • Run fwupdmgr get-devices in the VM and checked there are no errors in the journal.

Closes: #71140

@jtojnar
Copy link
Contributor Author

jtojnar commented Nov 18, 2019

1.3.3 does not seem to build:

Traceback (most recent call last):
  File "/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/lib/python3.7/site-packages/mesonbuild/mesonmain.py", line 127, in run
    return options.run_func(options)
  File "/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/lib/python3.7/site-packages/mesonbuild/minstall.py", line 514, in run
    installer.do_install(datafilename)
  File "/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/lib/python3.7/site-packages/mesonbuild/minstall.py", line 343, in do_install
    self.install_targets(d)
  File "/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/lib/python3.7/site-packages/mesonbuild/minstall.py", line 436, in install_targets
    raise RuntimeError('File {!r} could not be found'.format(t.fname))
RuntimeError: File 'plugins/uefi/efi/fwupdx64.efi' could not be found
FAILED: meson-install
/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/bin/meson install --no-rebuild

Most likely because of this:

[1/2] Generating fwupdx64.efi with a custom command.
/build/fwupd-1.3.3/plugins/uefi/efi/generate_binary.sh: line 3: which: not found
/build/fwupd-1.3.3/plugins/uefi/efi/generate_binary.sh: line 4: which: not found
/build/fwupd-1.3.3/plugins/uefi/efi/generate_binary.sh: line 6: -j: not found

@jtojnar
fwupd: 1.2.10 → 1.3.3
5b8998f 
https://github.com/fwupd/fwupd/blob/1.3.3/data/org.freedesktop.fwupd.metainfo.xml#L35-L125

systemd.tmpfiles should not be necessary, as the systemd service switched to StateDirectory.
@jtojnar jtojnar changed the title fwupd: 1.2.10 → 1.3.2 fwupd: 1.2.10 → 1.3.3 Nov 18, 2019
@jtojnar
Copy link
Contributor Author

jtojnar commented Nov 18, 2019

Do not have genpeimg to mark ASLR and DP/NX on EFI binary but it builds without it.

@jtojnar
Copy link
Contributor Author

jtojnar commented Nov 18, 2019

fwupdmgr seems to work fine in the VM, no warnings in the journal.

@jtojnar jtojnar merged commit 91b02cd into NixOS:master Nov 20, 2019
@jtojnar jtojnar deleted the fwupd-1.3 branch November 20, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Fwupd
2 participants
@jtojnar @worldofpeace