Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beets: fix absubmit deps #73608

Merged
merged 1 commit into from Nov 22, 2019
Merged

beets: fix absubmit deps #73608

merged 1 commit into from Nov 22, 2019

Conversation

lovesegfault
Copy link
Member

Motivation for this change

See #73589
TL;DR: Beets (tools/audio/beets) has a plugin called absubmit which relies on a statically linked binary provided by MusicBrainz.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aszlig @domenkozar @pjones

aszlig
aszlig approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@aszlig aszlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I have limited time now, but from roughly skimming over it, the changes at least don't look harmful :-)

@domenkozar domenkozar removed their request for review November 19, 2019 14:39
@lovesegfault
Copy link
Member Author

Pinging @pjones again

@lovesegfault
Copy link
Member Author

Can someone please help me push this through, cc. @andir @pjones

infinisil
infinisil approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@infinisil infinisil merged commit 9d3911f into NixOS:master Nov 22, 2019
@lovesegfault lovesegfault deleted the beets-absubmit branch April 7, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig aszlig approved these changes

@infinisil infinisil infinisil approved these changes

@pjones pjones Awaiting requested review from pjones

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @aszlig @infinisil