Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 - cannot use array offset on integers #137

Merged
merged 2 commits into from
Feb 12, 2020
Merged

PHP 7.4 - cannot use array offset on integers #137

merged 2 commits into from
Feb 12, 2020

Conversation

fisharebest
Copy link
Contributor

PHP 7.3 casts integers to strings.
PHP 7.4 throws the error Trying to access array offset on value of type int

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
PHP 7.3 casts integers to strings.
PHP 7.4 throws the error `Trying to access array offset on value of type int`
@CLAassistant
Copy link

CLAassistant commented Sep 20, 2019

CLA assistant check
All committers have signed the CLA.

@fisharebest
Copy link
Contributor Author

PHP 7.4 will be released in 2 days. Can we get this merged before then?

@DevinWalker
Copy link

Any progress on this?

@fisharebest
Copy link
Contributor Author

@DevinWalker - FYI, I am currently using composer-patches to apply this (and other) patches locally.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nicolaasuni nicolaasuni merged commit 621723c into tecnickcom:master Feb 12, 2020
@DevinWalker
Copy link

Thanks @fisharebest that's helpful. I'll proceed with that until it's released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants