New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7.4 - cannot use array offset on integers #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 7.3 casts integers to strings. PHP 7.4 throws the error `Trying to access array offset on value of type int`
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 20, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 25, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 25, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 25, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 25, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 25, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 26, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 26, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 26, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 27, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 28, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 29, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 29, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 30, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 30, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 31, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Oct 31, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 2, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 2, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 2, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 2, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 3, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 3, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 3, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 4, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 5, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 5, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 5, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 8, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 8, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 8, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 9, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 9, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 12, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 12, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 15, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 15, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 16, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 16, 2019
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Nov 17, 2019
PHP 7.4 will be released in 2 days. Can we get this merged before then? |
2 tasks
Any progress on this? |
@DevinWalker - FYI, I am currently using composer-patches to apply this (and other) patches locally. |
Thanks @fisharebest that's helpful. I'll proceed with that until it's released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.3 casts integers to strings.
PHP 7.4 throws the error
Trying to access array offset on value of type int