Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 - some more curly braces to fix #144

Closed
wants to merge 1 commit into from

Conversation

stronk7
Copy link

@stronk7 stronk7 commented Oct 20, 2019

While #134 fixed the majority of, now deprecated, curly braces
it seems that a few were left out.

ag '(\$[0-9a-zA-Z_]+|\))(\[[\w$]+\])?{[^\n=}]+}' --php | sort | uniq

This commit just converts them to square braces.

While tecnickcom#134 fixed the majority of, now deprecated, curly braces
it seems that a few were left out.

`ag '(\$[0-9a-zA-Z_]+|\))(\[[\w$]+\])?{[^\n=}]+}' --php | sort | uniq`

This commit just converts them to square braces.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 20, 2019
@stronk7
Copy link
Author

stronk7 commented Oct 20, 2019

I'm modifying this under the terms of the GNU LESSER GENERAL PUBLIC LICENSE Version 3, 29 June 2007 and providing the modifications to you under those very same terms.

So I'm not going to sign absolutely anything, I'm afraid. Feel free to ignore this pull request, pick it, change its authorship to another, signed, contributor or whatever you prefer.

Ciao :-)

PS: Thanks for your awesome library!

@fisharebest
Copy link
Contributor

@stronk7 - If you publish your code under the GPL, it makes it impossible to use in a project with a more restrictive licence.

Suggestion: place the code is in the public domain - and then someone can add it under a CLA.

@stronk7
Copy link
Author

stronk7 commented Oct 24, 2019

Sorry, @fisharebest, this project is exactly GNU LESSER GENERAL PUBLIC LICENSE| Version 3, 29 June 2007. And I'm sharing this patch 100% fulfilling its rules.

I don't need to follow any other "license" CLA to do so.

Now, they can do whatever they want with that patch, under the terms of the project license, of course. But I won't adhere to their CLA ever. It's their problem if it's compatible or no with the GNU, not mine (so I won't move out from it).

Ciao :-)

stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 25, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 25, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 25, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 25, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 25, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 26, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 26, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 26, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 27, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 28, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 29, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 29, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 30, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 30, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 31, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Oct 31, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 2, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 2, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 2, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 2, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 3, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 3, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 3, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 4, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 5, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 5, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 5, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 8, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 8, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 8, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 9, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 9, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 12, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 12, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 15, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 15, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 16, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 16, 2019
stronk7 added a commit to stronk7/moodle that referenced this pull request Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants